Fix CI failures by adding sleep backoff #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Jul 15, 2022
| teardown(() => { | ||
| sinon.restore(); | ||
| }); | ||
| standardSuiteSetup(this); |
There was a problem hiding this comment.
Notice how for some tests we were retrying 3 times, other times 5. I put this standard preamble into a utility function to encourage consistency
|
|
||
| // Check that setSelection is able to focus the correct cell | ||
| suite("Within cell set selection", async function () { | ||
| this.timeout("100s"); | ||
| this.retries(3); |
There was a problem hiding this comment.
In particular, notice that the test that was failing in CI was only retrying 3 times, instead of the usual 5
| @@ -24,7 +18,7 @@ async function runTest() { | |||
|
|
|||
| // FIXME: There seems to be some timing issue when you create a notebook | |||
| // editor | |||
| await sleep(1000); | |||
| await sleepWithBackoff(1000); | |||
There was a problem hiding this comment.
This will now cause it to sleep 250ms, then 500ms, 1s, 2s, 4s. Hopefully that will both speed things up locally, while resolving the CI issues on Mac / Win
AndreasArvidsson
approved these changes
Jul 15, 2022
|
Ok green 8 times in a row (the two "failures" in that streak are pre-commit complaining that there's a newer commit). Hopefully this one will last us a while 🤞 |
pokey
deleted the
pokey/issue845-Within-cell-set-selection-fails-non-deterministically-on-ci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sleeping the same amount of time every time we run a test, we double the sleep every time
Fixes #845
Checklist