Add support for domain, leading, trailing, interior #1427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
pokey
force-pushed
the
pokey/add-support-for-domain-leading-trailing-interior
branch
from
2cca025 to
ea5e9ce
Compare
pokey
changed the base branch from
bases/pokey/add-support-for-domain-leading-trailing-interior
to
main
pokey
changed the base branch from
main
to
bases/pokey/add-support-for-domain-leading-trailing-interior
pokey
commented
Apr 15, 2023
| @@ -13,3 +13,4 @@ | |||
| (regex) @regularExpression | |||
|
|
|||
| (class) @class | |||
| (class name: (_) @className) @domain | |||
There was a problem hiding this comment.
Should this shorthand be @_.domain instead to make it clearer that it's a related node rather than a different scope type?
pokey
force-pushed
the
bases/pokey/add-support-for-domain-leading-trailing-interior
branch
from
6825a23 to
f083bea
Compare
pokey
force-pushed
the
pokey/add-support-for-domain-leading-trailing-interior
branch
from
ea5e9ce to
fa186b1
Compare
pokey
commented
Apr 15, 2023
| ); | ||
|
|
||
| const interiorRange = getRelatedRange(match, scopeTypeType, "interior"); |
There was a problem hiding this comment.
Should we call this "inside"? That's the term everyone knows. I'd also be tempted to do a rename interior => inside in our code base, so maybe we should just do that in a follow-up
pokey
force-pushed
the
pokey/add-support-for-domain-leading-trailing-interior
branch
from
fa186b1 to
fd936cc
Compare
pokey
force-pushed
the
bases/pokey/add-support-for-domain-leading-trailing-interior
branch
from
f083bea to
aab6502
Compare
pokey
force-pushed
the
pokey/add-support-for-domain-leading-trailing-interior
branch
from
fd936cc to
b5772a8
Compare
pokey
force-pushed
the
bases/pokey/add-support-for-domain-leading-trailing-interior
branch
from
c0aeedf to
631aa40
Compare
pokey
force-pushed
the
pokey/add-support-for-domain-leading-trailing-interior
branch
from
b5772a8 to
4ff3022
Compare
pokey
force-pushed
the
pokey/add-support-for-domain-leading-trailing-interior
branch
from
4ff3022 to
06f3c99
Compare
pokey
changed the base branch from
bases/pokey/add-support-for-domain-leading-trailing-interior
to
main
pokey
changed the base branch from
main
to
bases/pokey/add-support-for-domain-leading-trailing-interior
|
superseded by #1430 |
pokey
deleted the
pokey/add-support-for-domain-leading-trailing-interior
branch
pokey
added a commit
that referenced
this pull request
Apr 19, 2023
- Partially addresses #616 - Partially addresses #436 - Depends on #1396 ## Todo - [x] **[DISCUSS]** What to do about fallback `iterationScope`? That's the only thing that is a regression here. - [x] File issues for FIXMEs - [x] File issue for defining iteration scopes. Can probably reuse most of the code from the regular scope handler other than creating the target - [x] File issue to add unit tests for scope handlers - [x] File issue to add some Python scope types where multiple can end at the same point (due to lack of closing brackets) - [x] Add test that checks no scope types are duplicated between legacy and new definition, or file issue to add test - [x] File PR for my 7783da6 (Add support for domain, leading, trailing, interior) #1427 - [x] Look through comments on this thread for anything worth filing / doing - [x] Open as new PR? - [x] Remove extraneous test cases - [x] Double check #629 (comment); a lot of those tests we already have for the generic modifier code - [x] Make sure changes to parse-tree-extension are shipped - [x] Close #785 if we fix that - [x] Comment on #484 saying the process has started and providing link to example - [x] Close #797 if we fix that --------- Co-authored-by: Pokey Rule <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_.domain,@_.leading,@_.trailing,@_.removal, and@_.interiortree-sitter query capturesChecklist