Search is disabled in browser runner window

[saschwarz]

Current behavior

Prior to 9.5.0(?) setting focus in the browser runner window and typing Cmd-F to search for text would search the text within the browser window. Now Cmd-F is captured and focus is shifted to the search bar in the Cypress app and the names of tests are searched.

I use search within the browser window as a normal part of my testing debugging workflow: to find specific steps, to find accessible roles that aren't matching exactly, to find logging, etc.

Desired behavior

Please restore the default browser search functionality

Test code to reproduce

No specific test code is required.

Cypress Version

9.5.0

Other

No response

[BlueWinds]

I agree this is not great usability.

It looks like this happened in #248, when we added test runner keyboard shortcuts (docs). In https://github.com/cypress-io/cypress/blob/develop/packages/reporter/src/lib/shortcuts.ts we're not checking for modifier keys (like ctrl) when deciding how to react to keypresses.

This is something we'd like to address, and I'll see when we can get to it; a pull request would be very welcome if anyone wants to create one, should be fairly straightforward.

[majidzeno]

I will work on this ✋

[majidzeno]

@saschwarz It's merged now 🎉

[BlueWinds]

Forgot to tag this with a release before merging, so the bot didn't comment properly. This is merged into the develop branch, and will go out with the next Cypress release.

[cypress-bot]

Released in 9.5.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.5.3, please open a new issue.