Skip to content

Conversation

majidzeno
Copy link
Contributor

User facing changelog

Cypress shortcuts updated to not conflict with the browser native shortcuts

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@majidzeno majidzeno requested a review from a team as a code owner February 26, 2022 21:56
@majidzeno majidzeno requested review from jennifer-shehane and removed request for a team February 26, 2022 21:56
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 26, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2022

CLA assistant check
All committers have signed the CLA.

@majidzeno
Copy link
Contributor Author

majidzeno commented Feb 27, 2022

@jennifer-shehane CI is failing, seems there is an issue with desktop-gui, can you check 🙏 ? Is there anything from my side I can do?

@jennifer-shehane
Copy link
Member

@majidzeno Is it possible to add a test around this behavior? The failures look like flaky tests.

@majidzeno
Copy link
Contributor Author

@jennifer-shehane I tried to reproduce this issue locally but the test passed, I checked the test and the onMount function seems to fire as expected, can we try to rerun the CI from the failed task once again? 🙏

@majidzeno
Copy link
Contributor Author

@jennifer-shehane I rebased my branch to the develop and seems the issue is still happening, this is weird cause it had to be already fixed before here, I will check this PR to find the why it is still flaky

@majidzeno
Copy link
Contributor Author

majidzeno commented Mar 4, 2022

@jennifer-shehane the flaky test is this.ipc.getUserEditor is not triggered every time, I think the reason behind that is the nature of useEffect which is used in onMount, it is triggered in first but the events will not flush until the next update, I think this solution is a bit hacky but I forced the component to update by changing the state, check the last commit.

@jennifer-shehane jennifer-shehane removed their request for review March 14, 2022 14:56
cy.get('button.stop').trigger('mouseover')
cy.get('.cy-tooltip').should('have.text', 'Stop Running S')
})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majidzeno - I went ahead and pushed a test for these changes onto your branch, this is what @jennifer-shehane was asking for.

Looks good to me. 👍

@jennifer-shehane
Copy link
Member

Kitchensink is failing in 'test-cypress-scaffold' due to known reasons that we're working on resolving.

@BlueWinds
Copy link
Contributor

Given that we know the test failure is unrelated (and I'm working on it in a separate ticket), I'm going to merge this as-is. Thanks for your contribution, @majidzeno :)

@BlueWinds BlueWinds merged commit f85a26b into cypress-io:develop Mar 15, 2022
@majidzeno
Copy link
Contributor Author

majidzeno commented Mar 15, 2022

@BlueWinds @jennifer-shehane Thanks a lot 🙏
That was my first contribution to cypress btw 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search is disabled in browser runner window
5 participants