-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: shortcuts conflict with browser native shortcuts #20375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking the time to open a PR!
|
d98fd61
to
0b5ff0b
Compare
@jennifer-shehane CI is failing, seems there is an issue with |
@majidzeno Is it possible to add a test around this behavior? The failures look like flaky tests. |
@jennifer-shehane I tried to reproduce this issue locally but the test passed, I checked the test and the |
@jennifer-shehane I rebased my branch to the |
@jennifer-shehane the flaky test is |
cy.get('button.stop').trigger('mouseover') | ||
cy.get('.cy-tooltip').should('have.text', 'Stop Running S') | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@majidzeno - I went ahead and pushed a test for these changes onto your branch, this is what @jennifer-shehane was asking for.
Looks good to me. 👍
Kitchensink is failing in 'test-cypress-scaffold' due to known reasons that we're working on resolving. |
Given that we know the test failure is unrelated (and I'm working on it in a separate ticket), I'm going to merge this as-is. Thanks for your contribution, @majidzeno :) |
@BlueWinds @jennifer-shehane Thanks a lot 🙏 |
User facing changelog
Cypress shortcuts updated to not conflict with the browser native shortcuts
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?