-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: bump resource class for tests that require node_modules install #19079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be really nice to not have to rerun these for this reason 🎉
Will leave merging this one to @flotwig |
In a perfect world, we wouldn't be doing any If so, I think that when #18574 merges we can go ahead and convert these tests that have dependencies to use |
@flotwig Though these tests aren't for testing examples, I believe they can still be converted to system tests. They were installing different deps so as to rerun the unit tests against them (for example, Webpack 4 vs Webpack 5), but having two different system tests (one to cover each dep we support) will suffice. |
* 10.0-release: refactor: remove @packages/desktop-gui (#19127) feat: switch browser runner (#19048) fix: bump resource class for tests that require node_modules install (#19079) fix(unify): reporter styles (#19034) fix test feat(unify): add number of matches to specs search (#19076) feat(launchpad): open in IDE modal and feature (#18975) fix: 10.0 appveyor updateyaml (#19074)
Details
npm-webpack-preprocessor
andnpm-webpack-dev-server
were flaky on CI. These tests both require ayarn install
which was causing the agent to run out of memory. This PR bumps theresource_class
for both of these tests to mediumBefore:

https://app.circleci.com/pipelines/github/cypress-io/cypress/27313/workflows/48943cd1-1381-42ef-b5c3-93a50b68f424/jobs/1031151/steps
After:

https://app.circleci.com/pipelines/github/cypress-io/cypress/27315/workflows/ebc15162-ae83-430f-97d8-add2ac352620/jobs/1031282