Skip to content

Conversation

ZachJW34
Copy link
Contributor

Details

npm-webpack-preprocessor and npm-webpack-dev-server were flaky on CI. These tests both require a yarn install which was causing the agent to run out of memory. This PR bumps the resource_class for both of these tests to medium

Before:
https://app.circleci.com/pipelines/github/cypress-io/cypress/27313/workflows/48943cd1-1381-42ef-b5c3-93a50b68f424/jobs/1031151/steps
Screen Shot 2021-11-23 at 4 52 41 PM

After:
https://app.circleci.com/pipelines/github/cypress-io/cypress/27315/workflows/ebc15162-ae83-430f-97d8-add2ac352620/jobs/1031282
Screen Shot 2021-11-23 at 5 22 01 PM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 23, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 23, 2021



Test summary

18699 0 204 0Flakiness 4


Run details

Project cypress
Status Passed
Commit 41eb6a1
Started Nov 24, 2021 3:21 PM
Ended Nov 24, 2021 3:33 PM
Duration 12:08 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > should delay the same amount on every response
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
3 network stubbing > waiting and aliasing > can timeout incrementally waiting on requests
settings_spec.js Flakiness
1 Settings > file preference panel > loads preferred editor, available editors and shows spinner

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34 ZachJW34 requested a review from flotwig November 23, 2021 23:33
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be really nice to not have to rerun these for this reason 🎉

@lmiller1990
Copy link
Contributor

Will leave merging this one to @flotwig

@flotwig
Copy link
Contributor

flotwig commented Nov 24, 2021

In a perfect world, we wouldn't be doing any yarn install outside of the root node_modules_install. It's just for the example projects that we need it for these 2 jobs, right?

If so, I think that when #18574 merges we can go ahead and convert these tests that have dependencies to use system-tests instead, and maybe even drop these circle jobs altogether. Is there an issue or task created for this yet? Created an issue to track converting these to system-tests: #19088

@ZachJW34
Copy link
Contributor Author

@flotwig Though these tests aren't for testing examples, I believe they can still be converted to system tests. They were installing different deps so as to rerun the unit tests against them (for example, Webpack 4 vs Webpack 5), but having two different system tests (one to cover each dep we support) will suffice.

@ZachJW34 ZachJW34 merged commit 0c9d45a into 10.0-release Nov 24, 2021
@ZachJW34 ZachJW34 deleted the fix-flaky-webpack-preprocessor branch November 24, 2021 16:28
tgriesser added a commit that referenced this pull request Nov 29, 2021
* 10.0-release:
  refactor: remove @packages/desktop-gui (#19127)
  feat: switch browser runner (#19048)
  fix: bump resource class for tests that require node_modules install (#19079)
  fix(unify): reporter styles (#19034)
  fix test
  feat(unify): add number of matches to specs search (#19076)
  feat(launchpad): open in IDE modal and feature (#18975)
  fix: 10.0 appveyor updateyaml (#19074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants