refactor: remove @packages/desktop-gui #19127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgriesser
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
tgriesser
changed the title
lmiller1990
approved these changes
Nov 28, 2021
tgriesser
added a commit
that referenced
this pull request
Nov 29, 2021
* 10.0-release: refactor: remove @packages/desktop-gui (#19127) feat: switch browser runner (#19048) fix: bump resource class for tests that require node_modules install (#19079) fix(unify): reporter styles (#19034) fix test feat(unify): add number of matches to specs search (#19076) feat(launchpad): open in IDE modal and feature (#18975) fix: 10.0 appveyor updateyaml (#19074)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@packages/desktop-guievents.tswhich we still might want to reference while building out the data-context layerWhile working on the new codepaths, particularly around config management, I found a number of situations where we were working around legacy concepts in tests which were only referenced from the current
desktop-gui. By going through and auditing the code-usage from this API layer, and removing all associated code, it reduces the surface area of the code significantly and thus means we can make changes without needing to worry about tests/code that doesn't matter. It also makes it more apparent what still needs to be added in the new codepaths.If we need to reference any of this code, we can find it in
develop/ in the git history.