chore: Refactoring to support e2e testing #19306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
* 10.0-release: (53 commits) refactor: makeLegacyContext -> getCtx (#19308) fix: various Nav Bar fixes (#19283) build: add patch package as a dev dependency for fe-shared chore: hoist is - fun with cached dependencies build: hoist is hard build: better hoisting strategy chore: remove unused testing preferences (#19301) fix: remove windows and mac workflow from branch fix: show script errors when spec file fails to process (#19298) revert: remove change about node version 17 feat: open config file in user's editor (#19276) feat(unify): scale the AUT (#19297) build: remove testing of desktop-gui assets build: run window & mac CI in this branch build: more fixes build: remove toycode mdi from launchpad rename patch because of dev dep build: fix merge issue in packages generation chore: update sass for windows compatibility fix: Do not crash when a ill formed URL request is proxied (#19274) ...
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
* refactor: getting e2e tests to a better state * fix types & tests * Remove unnecessary intercept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller changes split out from #18906, focused on testing improvements:
modeOptions(sourced from CLI flags) as a property on the data contextgetCtx/setCtxfor simpler testing & access to the context in places we can't inject itcy.openE2E('fixture-project-name', ['--browser', 'firefox'])yarn watch/yarn cypress:openwork w/ new development scriptsTodo:
cy.scaffoldProject- for scaffolding inbefore, without cleaning upcy.openProject('project-name')cy.initializeApp->cy.startAppServercy.withCtx, general testing best practices