-
Notifications
You must be signed in to change notification settings - Fork 3.4k
breaking: Signal removal of official support for direct download of Cypress #32249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ypress BREAKING: Signal removal of official support for direct download of Cypress
The recommended way to install Cypress is as a devDependency per project. | ||
You should probably run these commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe get rid of the probably here?
You should probably run these commands: | |
You should run these commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'm not sure that we KNOW they globally installed it. I almost removed this as well.... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yeah. The wording does make it seem like we do not know for sure
The recommended way to install Cypress is as a devDependency per project. | ||
You should probably run these commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably run these commands: | |
You should run these commands: |
cypress
|
Project |
cypress
|
Branch Review |
remove-direct-dl-support
|
Run status |
|
Run duration | 19m 39s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
12
|
|
1101
|
|
0
|
|
26543
|
View all changes introduced in this branch ↗︎ |
UI Coverage
44.99%
|
|
---|---|
|
187
|
|
157
|
Accessibility
97.71%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
110
|
Co-authored-by: Mike McCready <[email protected]>
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
BREAKING: Signal removal of official support for direct download of Cypress
Additional details
See thread
There are official differences between the binary when downloaded directly or via a package manager. These can be very difficult to track down and test by our team.
Additionally, the direct downloads make up an extremely small percentage of downloads of Cypress.
Steps to test
No effective changes to test
How has the user experience changed?
No changes effectively - we want users to be aware that this will no longer be supported. We may followup with cleanup on the repo. Will followup removing instructions on docs/public website.
PR Tasks
cypress-documentation
?type definitions
?