Skip to content

Updating sched api on DaprContainer #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

salaboy
Copy link
Collaborator

@salaboy salaboy commented Jul 21, 2025

Description

Align Scheduler and Placement APIs on DaprContainer

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1461

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners July 21, 2025 08:05
@salaboy salaboy force-pushed the 1461-placement-and-sched-apis-container branch from 88aa014 to 32b033e Compare July 21, 2025 08:05
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@dapr-bot dapr-bot merged commit 1e62c73 into dapr:master Jul 22, 2025
9 checks passed
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (d759c53) to head (32b033e).
Report is 184 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1462      +/-   ##
============================================
+ Coverage     76.91%   78.34%   +1.42%     
- Complexity     1592     1883     +291     
============================================
  Files           145      234      +89     
  Lines          4843     5850    +1007     
  Branches        562      603      +41     
============================================
+ Hits           3725     4583     +858     
- Misses          821      945     +124     
- Partials        297      322      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

salaboy added a commit to salaboy/java-sdk that referenced this pull request Jul 22, 2025
cicoyle pushed a commit that referenced this pull request Jul 23, 2025
* adding app health check parameters

Signed-off-by: salaboy <[email protected]>

* fixing style

Signed-off-by: salaboy <[email protected]>

* testing with configure for coverage

Signed-off-by: salaboy <[email protected]>

* updating sched api on DaprContainer (#1462)

Signed-off-by: salaboy <[email protected]>

* fix Artur comments

Signed-off-by: salaboy <[email protected]>

---------

Signed-off-by: salaboy <[email protected]>
siri-varma pushed a commit to siri-varma/java-sdk that referenced this pull request Aug 6, 2025
siri-varma pushed a commit to siri-varma/java-sdk that referenced this pull request Aug 6, 2025
* adding app health check parameters

Signed-off-by: salaboy <[email protected]>

* fixing style

Signed-off-by: salaboy <[email protected]>

* testing with configure for coverage

Signed-off-by: salaboy <[email protected]>

* updating sched api on DaprContainer (dapr#1462)

Signed-off-by: salaboy <[email protected]>

* fix Artur comments

Signed-off-by: salaboy <[email protected]>

---------

Signed-off-by: salaboy <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align APIs for Placement and Scheduler on DaprContainer
4 participants