-
Notifications
You must be signed in to change notification settings - Fork 223
Updating sched api on DaprContainer #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating sched api on DaprContainer #1462
Conversation
Signed-off-by: salaboy <[email protected]>
88aa014
to
32b033e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
============================================
+ Coverage 76.91% 78.34% +1.42%
- Complexity 1592 1883 +291
============================================
Files 145 234 +89
Lines 4843 5850 +1007
Branches 562 603 +41
============================================
+ Hits 3725 4583 +858
- Misses 821 945 +124
- Partials 297 322 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: salaboy <[email protected]>
* adding app health check parameters Signed-off-by: salaboy <[email protected]> * fixing style Signed-off-by: salaboy <[email protected]> * testing with configure for coverage Signed-off-by: salaboy <[email protected]> * updating sched api on DaprContainer (#1462) Signed-off-by: salaboy <[email protected]> * fix Artur comments Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]> Signed-off-by: sirivarma <[email protected]>
* adding app health check parameters Signed-off-by: salaboy <[email protected]> * fixing style Signed-off-by: salaboy <[email protected]> * testing with configure for coverage Signed-off-by: salaboy <[email protected]> * updating sched api on DaprContainer (dapr#1462) Signed-off-by: salaboy <[email protected]> * fix Artur comments Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: sirivarma <[email protected]>
Description
Align Scheduler and Placement APIs on DaprContainer
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1461
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: