Adding app health check parameters #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaboy
force-pushed
the
1464-app-healthchecks
branch
2 times, most recently
from
b408835 to
b06a691
Compare
|
Flaky Tests: |
salaboy
force-pushed
the
1464-app-healthchecks
branch
from
2ffd4ed to
7c28668
Compare
artur-ciocanu
previously approved these changes
Jul 22, 2025
testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprContainerTest.java
Outdated
Show resolved
Hide resolved
testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprContainerTest.java
Show resolved
Hide resolved
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
salaboy
force-pushed
the
1464-app-healthchecks
branch
from
6a4fb77 to
485fca9
Compare
|
@artur-ciocanu thanks for the comments.. all fixed. |
cicoyle
approved these changes
Jul 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1465 +/- ##
============================================
+ Coverage 76.91% 78.51% +1.59%
- Complexity 1592 1891 +299
============================================
Files 145 234 +89
Lines 4843 5869 +1026
Branches 562 603 +41
============================================
+ Hits 3725 4608 +883
- Misses 821 938 +117
- Partials 297 323 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
siri-varma
pushed a commit
to siri-varma/java-sdk
that referenced
this pull request
Aug 6, 2025
* adding app health check parameters Signed-off-by: salaboy <[email protected]> * fixing style Signed-off-by: salaboy <[email protected]> * testing with configure for coverage Signed-off-by: salaboy <[email protected]> * updating sched api on DaprContainer (dapr#1462) Signed-off-by: salaboy <[email protected]> * fix Artur comments Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: sirivarma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding appHealthCheck: interval, timeout and threshold.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1464
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: