This repository was archived by the owner on Jan 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jakemac53 also, if the changes looks good to you, we could publish this, right? |
Note that we still might deprecate some of the things of this package and move them to |
jakemac53
reviewed
Nov 13, 2020
Co-authored-by: Jacob MacDonald <[email protected]>
@jakemac53 this is fine to publish now, right? |
@dcharkes as you requested, I've changed this to |
jakemac53
reviewed
Nov 16, 2020
jakemac53
approved these changes
Nov 16, 2020
Co-authored-by: Jacob MacDonald <[email protected]>
@jakemac53 this can be published, right? |
dcharkes
added a commit
that referenced
this pull request
Nov 16, 2020
* enable using package in NNBD * Update to null safety in 2.12 (#60) Co-authored-by: Daco Harkes <[email protected]>
dcharkes
added a commit
to dart-lang/native
that referenced
this pull request
Jan 16, 2024
* enable using package in NNBD * Update to null safety in 2.12 (dart-archive/ffi#60) Co-authored-by: Daco Harkes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a few lints from pedantic