Skip to content
This repository was archived by the owner on Jan 17, 2024. It is now read-only.

Merge null safety branch to master #62

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Merge null safety branch to master #62

merged 2 commits into from
Nov 16, 2020

Conversation

mit-mit
Copy link
Contributor

@mit-mit mit-mit commented Nov 16, 2020

From chatting with @jakemac53, the recommendation is to move null safety to the master branches now that we're prepping for beta.

@mit-mit
Copy link
Contributor Author

mit-mit commented Nov 16, 2020

Also, once this lands, would be great to roll this to the SDK DEPS.

@dcharkes
Copy link
Contributor

Just to double check, do we want to release package versions through master, and stop maintaining a legacy branch? (Anyone wanting to use new features that get landed, for example #61, would have to opt in to NNBD?)

@jakemac53
Copy link

Note that users don't have to update to NNBD to use new features, but they do have to update to the >=2.12.x sdk

@dcharkes
Copy link
Contributor

2.12 is only on beta right? not on stable?

I was under the impression we only publish dev releases for packages with SDK constraints that are a beta or dev branch. If we have a different policy with the NNBD migration, that is fine by me.

@jakemac53
Copy link

I was under the impression we only publish dev releases for packages with SDK constraints that are a beta or dev branch.

This is a pre-release, we just are using a more specific -nullsafety name for it instead of -dev

@dcharkes
Copy link
Contributor

I see, so master branch, but -nullsafety.x version name. 👍

@dcharkes dcharkes merged commit a5d4232 into master Nov 16, 2020
@dcharkes
Copy link
Contributor

@dcharkes dcharkes deleted the null_safety branch February 1, 2021 15:57
dcharkes added a commit to dart-lang/native that referenced this pull request Jan 16, 2024
* enable using package in NNBD

* Update to null safety in 2.12 (dart-archive/ffi#60)

Co-authored-by: Daco Harkes <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants