Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

extension type support for hash_and_equals #4673

Merged
merged 1 commit into from
Aug 11, 2023
Merged

extension type support for hash_and_equals #4673

merged 1 commit into from
Aug 11, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented Aug 11, 2023

@coveralls
Copy link

Coverage Status

coverage: 96.543%. remained the same when pulling f79ca3f on hash_and_equals_extensionTypes into 3e07457 on main.

bwilkerson
bwilkerson approved these changes Aug 11, 2023
View reviewed changes
test/rules/hash_and_equals_test.dart
bool operator ==(Object other) => false;
}
''', [
// No lint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm similarly unconvinced that this test is particularly useful, though I guess I don't object too much here because there's nothing else to test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal here is to ensure we don't report a lint where there's already an error (since you can't redeclare hash or == in extension types).

@pq pq merged commit 6202c50 into main Aug 11, 2023
@pq pq deleted the hash_and_equals_extensionTypes branch August 11, 2023 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hash_and_equals support for extension types
3 participants
@pq @coveralls @bwilkerson