Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

+ example #36

Merged
merged 3 commits into from
May 13, 2021
Merged

+ example #36

merged 3 commits into from
May 13, 2021

Conversation

pq
Copy link
Contributor

@pq pq commented May 13, 2021 •
edited
Loading

Fixes: dart-lang/core#746.

☁  lints [example] pub global run pana
INFO       Running `/Applications/Tools/dart-sdk/bin/dart --version`...
INFO       Running `flutter --no-version-check --version --machine`...
WARNING    pana might update or modify files in `.`.
           Analysis will begin in 15 seconds, hit CTRL+C to abort it.
           To remove this message, use `--no-warning`.
INFO       Running `/Applications/Tools/dart-sdk/bin/dart pub upgrade --verbose`...
INFO       Analyzing package...
INFO       Running `/Applications/Tools/dart-sdk/bin/dart pub get`...
INFO       Running `/Applications/Tools/dart-sdk/bin/dart pub outdated --json --up-to-date --no-dev-dependencies --no-dependency-overrides`...

## ✓ Follow Dart file conventions (20 / 20)
### [*] 10/10 points: Provide a valid `pubspec.yaml`


### [*] 5/5 points: Provide a valid `README.md`


### [*] 5/5 points: Provide a valid `CHANGELOG.md`


## ✓ Provide documentation (10 / 10)
### [*] 10/10 points: Package has an example

* Found example at: `example/README.md`

## ✓ Support multiple platforms (20 / 20)
### [*] 20/20 points: Supports 2 of 2 possible platforms (**native**, **js**)


## ✓ Pass static analysis (30 / 30)
### [*] 30/30 points: code has no errors, warnings, lints, or formatting issues


## ✓ Support up-to-date dependencies (20 / 20)
### [*] 10/10 points: All of the package dependencies are supported in the latest version

No dependencies.

To reproduce run `dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides`.


### [*] 10/10 points: Package supports latest stable Dart and Flutter SDKs


## ✓ Support sound null safety (20 / 20)
### [*] 20/20 points: Package and dependencies are fully migrated to null safety!


Points: 120/120.

/cc @devoncarew @mit-mit

devoncarew
devoncarew approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@devoncarew devoncarew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to include any sample dart code which gets linted? A hello world in example/lib or example/bin?

@goderbauer goderbauer mentioned this pull request May 13, 2021
Merged
goderbauer
goderbauer approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pq
Copy link
Contributor Author

pq commented May 13, 2021

Do we want to include and sample dart code which gets linted?

Not sure... If you have concrete ideas, feel free to follow-up with another PR?

@pq pq merged commit f9670df into main May 13, 2021
@pq pq deleted the example branch May 13, 2021 18:12
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
@pq
+ example (dart-archive/lints#36)
d33a960 
* + example

* publish_to: none

* docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider adding an example dir (for more pub points)
3 participants
@pq @goderbauer @devoncarew