Skip to content

Add example to flutter_lints package #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 13, 2021
Merged

Add example to flutter_lints package #354

merged 8 commits into from
May 13, 2021

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented May 13, 2021

for more points on pub.dev :)

Inspired by dart-archive/lints#36.

@goderbauer goderbauer requested a review from pq May 13, 2021 18:04
@google-cla google-cla bot added the cla: yes label May 13, 2021
Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pq
Copy link
Contributor

pq commented May 13, 2021

@goderbauer or @devoncarew, if you want to lift the example source and drop it into package:lints I say go for it.

Note that if we add source, we'll need to update this validation though:

https://github.com/dart-lang/lints/blob/f9670df2a66e0ec12eb51554e70c1cbf56c8f5d0/.github/workflows/validate.yml#L24

@goderbauer
Copy link
Member Author

Note that if we add source, we'll need to update this validation though:

Oh, right. I will have to do the same for the check in this package...

@@ -3,6 +3,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

# Dart sources are only allowed in the example directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

file. The lints enforced for this project can be further customized in that
file.

The dart code in this project (e.g. `lib/main.dart`) is analyzed using the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dart ==> Dart

@fluttergithubbot fluttergithubbot merged commit f18ba69 into flutter:master May 13, 2021
@goderbauer goderbauer deleted the example branch May 13, 2021 19:53
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
await runZoned Futures in the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants