Skip to content

[ffi] Windows DynamicLibrary.process() supported #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcharkes opened this issue Apr 5, 2023 · 0 comments
Closed

[ffi] Windows DynamicLibrary.process() supported #2005

dcharkes opened this issue Apr 5, 2023 · 0 comments
Assignees

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Apr 5, 2023

  • LibTest/ffi/DynamicLibrary/DynamicLibrary.process_A02_t01

DynamicLibrary.process() no longer throws on Windows, because we have added suport: https://dart-review.googlesource.com/c/sdk/+/260760

Tests should be updated to expect the same on Windows and non-Windows.

@sgrekhov sgrekhov self-assigned this Apr 6, 2023
@eernstg eernstg closed this as completed in d42cd47 Apr 7, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 14, 2023
2023-04-11 [email protected] dart-lang/co19#1401. Exhaustiveness tests fixed and new ones added (dart-lang/co19#2019)
2023-04-11 [email protected] Fixes dart-lang/co19#2006. `Pointer` can have top types as type arguments (dart-lang/co19#2013)
2023-04-11 [email protected] Fixes dart-lang/co19#2010. Fix exhaustiveness tests for a cast-pattern (dart-lang/co19#2018)
2023-04-07 [email protected] Fixes dart-lang/co19#2004. Update expected errors locations for CFE (dart-lang/co19#2011)
2023-04-07 [email protected] Fixes dart-lang/co19#2005. DynamicLibrary.process() is supported on Windows (dart-lang/co19#2012)
2023-04-07 [email protected] Fixes dart-lang/co19#2007. Fix UintPtr_A01_t01.dart not to fail on 32-bit platforms (dart-lang/co19#2014)
2023-04-07 [email protected] Fixes dart-lang/co19#2008. Split pattern_context_A01_t01.dart test to multiple methods (dart-lang/co19#2015)
2023-04-07 [email protected] Fixes dart-lang/co19#2009. Update scope_A01_t01.dart according to the current CFE behavior (dart-lang/co19#2016)

Change-Id: I5b43a5c5f133dded30564749b38f6a0c965b62fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295281
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants