#1401. Exhaustiveness tests fixed and new ones added #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Apr 11, 2023
| @@ -11,7 +11,7 @@ | |||
| // SharedOptions=--enable-experiment=patterns | |||
|
|
|||
| String test1(Map<bool, bool> m) => | |||
| switch (m) { | |||
| switch (m) { // Empty map is not matched | |||
There was a problem hiding this comment.
We should probably get into a habit of adding a comment whenever we have a non-trivial discussion. If we do this all the time for many days, and we have to discuss "what should this code do?" then surely it will be helpful for a future reader of the code to get a hint about the contents and outcomes of those discussions.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 14, 2023
2023-04-11 [email protected] dart-lang/co19#1401. Exhaustiveness tests fixed and new ones added (dart-lang/co19#2019) 2023-04-11 [email protected] Fixes dart-lang/co19#2006. `Pointer` can have top types as type arguments (dart-lang/co19#2013) 2023-04-11 [email protected] Fixes dart-lang/co19#2010. Fix exhaustiveness tests for a cast-pattern (dart-lang/co19#2018) 2023-04-07 [email protected] Fixes dart-lang/co19#2004. Update expected errors locations for CFE (dart-lang/co19#2011) 2023-04-07 [email protected] Fixes dart-lang/co19#2005. DynamicLibrary.process() is supported on Windows (dart-lang/co19#2012) 2023-04-07 [email protected] Fixes dart-lang/co19#2007. Fix UintPtr_A01_t01.dart not to fail on 32-bit platforms (dart-lang/co19#2014) 2023-04-07 [email protected] Fixes dart-lang/co19#2008. Split pattern_context_A01_t01.dart test to multiple methods (dart-lang/co19#2015) 2023-04-07 [email protected] Fixes dart-lang/co19#2009. Update scope_A01_t01.dart according to the current CFE behavior (dart-lang/co19#2016) Change-Id: I5b43a5c5f133dded30564749b38f6a0c965b62fe Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295281 Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes according to #1987 review