Skip to content

Test updates needed after [cfe] Create enum elements through SourcePropertyBuilder #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnniwinther opened this issue Jan 14, 2025 · 2 comments
Closed

Test updates needed after [cfe] Create enum elements through SourcePropertyBuilder #3044

johnniwinther opened this issue Jan 14, 2025 · 2 comments
Assignees
@sgrekhov
Labels
area-test

Comments

@johnniwinther
Copy link
Member

Theses tests needs to be updated after [cfe] Create enum elements through SourcePropertyBuilder has landed:

co19/Language/Classes/Constructors/Generative_Constructors/initializers_t19 MissingCompileTimeError (expected Pass)
co19/Language/Classes/Constructors/Generative_Constructors/initializing_formal_parameter_A02_t01 MissingCompileTimeError (expected Pass)
co19/Language/Classes/Constructors/Generative_Constructors/initializing_formal_parameter_A02_t02 MissingCompileTimeError (expected Pass)
co19/Language/Classes/Constructors/Generative_Constructors/initializing_formal_parameter_A02_t03 MissingCompileTimeError (expected Pass)
co19/Language/Classes/Constructors/Generative_Constructors/initializing_formal_parameter_A02_t04 MissingCompileTimeError (expected Pass)
@sgrekhov sgrekhov self-assigned this Jan 14, 2025
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 14, 2025
@sgrekhov
Fixes dart-lang#3044. Update expected errors positions for CFE
4359cca
@sgrekhov
Copy link
Contributor

@johnniwinther what about

co19/LanguageFeatures/Enhanced-Enum/semantics_A06_t07
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t05
co19/LanguageFeatures/Enhanced-Enum/semantics_A14_t01

Do I understand it right that these tests also should be updated?

@johnniwinther
Copy link
Member Author

Yes, they should. Thanks for catching these!

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 17, 2025
@sgrekhov
[co19] Roll co19 to e1fd1cf868e6fb778c426058737ad0c02122df33
b93c826 
2025-01-17 [email protected] Fixes dart-lang/co19#3044. Update expected errors positions for CFE (dart-lang/co19#3046)
2025-01-15 [email protected] dart-lang/co19#2976. Add more tests for records, factories and parenthesized expressions (dart-lang/co19#3047)
2025-01-15 [email protected] dart-lang/co19#2119. Actualize nnbd/static_errors_A12* description (dart-lang/co19#3048)
2025-01-14 [email protected] Fixes dart-lang/co19#3029. Add more tests for constants (dart-lang/co19#3045)
2025-01-14 [email protected] dart-lang/co19#2976. Add patterns tests (dart-lang/co19#3031)
2025-01-13 [email protected] dart-lang/co19#2976. Add more operators tests (dart-lang/co19#3043)
2025-01-13 [email protected] dart-lang/co19#3030. Add tests constants tests for String.length (dart-lang/co19#3041)
2025-01-13 [email protected] Fixes dart-lang/co19#3038. Read link to finalized object to avoid early finalization (dart-lang/co19#3042)
2025-01-10 [email protected] dart-lang/co19#2976. Add non-ambiguity tests (dart-lang/co19#3034)
2025-01-10 [email protected] dart-lang/co19#2976. Add more grammar tests (dart-lang/co19#3035)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I9feb50a33b33e85dc017d0d47829502d4f631ac7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405001
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
area-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @johnniwinther