Fixes #3044. Update expected errors positions for CFE #3046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, this is not done yet? |
|
Done but waiting for landing of https://dart-review.googlesource.com/c/sdk/+/404103 |
|
OK, thanks! |
|
https://dart-review.googlesource.com/c/sdk/+/404103 was landed. Please review |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 17, 2025
2025-01-17 [email protected] Fixes dart-lang/co19#3044. Update expected errors positions for CFE (dart-lang/co19#3046) 2025-01-15 [email protected] dart-lang/co19#2976. Add more tests for records, factories and parenthesized expressions (dart-lang/co19#3047) 2025-01-15 [email protected] dart-lang/co19#2119. Actualize nnbd/static_errors_A12* description (dart-lang/co19#3048) 2025-01-14 [email protected] Fixes dart-lang/co19#3029. Add more tests for constants (dart-lang/co19#3045) 2025-01-14 [email protected] dart-lang/co19#2976. Add patterns tests (dart-lang/co19#3031) 2025-01-13 [email protected] dart-lang/co19#2976. Add more operators tests (dart-lang/co19#3043) 2025-01-13 [email protected] dart-lang/co19#3030. Add tests constants tests for String.length (dart-lang/co19#3041) 2025-01-13 [email protected] Fixes dart-lang/co19#3038. Read link to finalized object to avoid early finalization (dart-lang/co19#3042) 2025-01-10 [email protected] dart-lang/co19#2976. Add non-ambiguity tests (dart-lang/co19#3034) 2025-01-10 [email protected] dart-lang/co19#2976. Add more grammar tests (dart-lang/co19#3035) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I9feb50a33b33e85dc017d0d47829502d4f631ac7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405001 Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]> Commit-Queue: Erik Ernst <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.