Skip to content

Fixes #3044. Update expected errors positions for CFE #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

sgrekhov
Copy link
Contributor

No description provided.

@sgrekhov sgrekhov marked this pull request as draft January 14, 2025 14:58
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg
Copy link
Member

eernstg commented Jan 14, 2025

Ah, this is not done yet?

@sgrekhov
Copy link
Contributor Author

Done but waiting for landing of https://dart-review.googlesource.com/c/sdk/+/404103

@eernstg
Copy link
Member

eernstg commented Jan 15, 2025

OK, thanks!

@sgrekhov sgrekhov marked this pull request as ready for review January 16, 2025 17:31
@sgrekhov
Copy link
Contributor Author

https://dart-review.googlesource.com/c/sdk/+/404103 was landed. Please review

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit e1fd1cf into dart-lang:master Jan 17, 2025
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 17, 2025
2025-01-17 [email protected] Fixes dart-lang/co19#3044. Update expected errors positions for CFE (dart-lang/co19#3046)
2025-01-15 [email protected] dart-lang/co19#2976. Add more tests for records, factories and parenthesized expressions (dart-lang/co19#3047)
2025-01-15 [email protected] dart-lang/co19#2119. Actualize nnbd/static_errors_A12* description (dart-lang/co19#3048)
2025-01-14 [email protected] Fixes dart-lang/co19#3029. Add more tests for constants (dart-lang/co19#3045)
2025-01-14 [email protected] dart-lang/co19#2976. Add patterns tests (dart-lang/co19#3031)
2025-01-13 [email protected] dart-lang/co19#2976. Add more operators tests (dart-lang/co19#3043)
2025-01-13 [email protected] dart-lang/co19#3030. Add tests constants tests for String.length (dart-lang/co19#3041)
2025-01-13 [email protected] Fixes dart-lang/co19#3038. Read link to finalized object to avoid early finalization (dart-lang/co19#3042)
2025-01-10 [email protected] dart-lang/co19#2976. Add non-ambiguity tests (dart-lang/co19#3034)
2025-01-10 [email protected] dart-lang/co19#2976. Add more grammar tests (dart-lang/co19#3035)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I9feb50a33b33e85dc017d0d47829502d4f631ac7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405001
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants