Skip to content

[Dot Shorthands] Rename the static access shorthand feature experiment flag #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kallentu opened this issue Feb 5, 2025 · 2 comments
Closed

[Dot Shorthands] Rename the static access shorthand feature experiment flag #3067

kallentu opened this issue Feb 5, 2025 · 2 comments
Assignees
@sgrekhov
Labels
area-test

Comments

@kallentu
Copy link
Member

kallentu commented Feb 5, 2025

@sgrekhov
https://dart-review.googlesource.com/c/sdk/+/407603 fails currently because it's hanging from all the co19 tests using enum-shorthands which is an unknown experiment flag after we rename it to dot-shorthands.

The solution is to make sure the tests use a known experiment. So I'm creating an issue to ask if we could rename all flags in the co19/LanguageFeatures/Static-access-shorthand tests to dot-shorthands and I'll update the DEPS in that PR so we can sync the new flag with the tests using it.

Thanks!
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 6, 2025
@sgrekhov
Fixes dart-lang#3067. Rename the static access shorthand feature expe…
d8d8c8b 
…riment flag
@eernstg eernstg closed this as completed in b14b080 Feb 6, 2025
@sgrekhov
Copy link
Contributor

sgrekhov commented Feb 6, 2025

@kallentu the experimental flag in co19 shorthand tests was updated. I've done a roll, but to the commit prior to this one. So, in your CL, change the co19 revision to b14b080, and this update will only contain changes to experimental flags.

@kallentu
Copy link
Member Author

kallentu commented Feb 7, 2025

That's perfect, thank you so much @sgrekhov.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 7, 2025
@kallentu
[dot-shorthands][co19] Rename enum-shorthands flag to dot-shorthands …
89e545c 
…(and roll co19 to b14b080)

We've decided to rename enum shorthands to dot shorthands. It describes the entire feature better. It's not only for enum values. We'll update the experiment name before the implementation goes in, that way our users can use a flag that matches the actual feature name.

Additionally, roll co19 to b14b0802e696a60c79b00d0f052e26fb986f0faf so we can avoid an infra failure with co19 using what's now an unknown feature flag (enum-shorthands).

2025-02-06 [email protected] Fixes dart-lang/co19#3067. Rename the static access shorthand feature experiment flag (dart-lang/co19#3068)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Bug: #57037
Change-Id: I031e3bce8166145b24dbb77acf259d78e6e00f0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407603
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
area-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @kallentu