Skip to content

[Dot Shorthands] Experiment flag #57037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 of 3 tasks
Tracked by #57036
kallentu opened this issue Nov 5, 2024 · 3 comments
Open
2 of 3 tasks
Tracked by #57036

[Dot Shorthands] Experiment flag #57037

kallentu opened this issue Nov 5, 2024 · 3 comments
Assignees
@kallentu
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). feature-dot-shorthands Implementation of the dot shorthands feature. type-enhancement A request for a change that isn't a bug

Comments

@kallentu
Copy link
Member

kallentu commented Nov 5, 2024 •
edited
Loading

Add an experiment flag to Dart and put all implementation code under it.

The implementation issue for a potential new language feature being considered: dart-lang/language#357

Checklist for experiment flag

  • Add an experiment flag named dot-shorthands
  • Eventually, add an experiment and release version to gate the feature.
  • Then enable by default when ready to release.
@kallentu kallentu added the feature-dot-shorthands Implementation of the dot shorthands feature. label Nov 5, 2024
@kallentu kallentu self-assigned this Nov 5, 2024
@kallentu kallentu mentioned this issue Nov 5, 2024
Open
21 tasks
@dart-github-bot
Copy link
Collaborator

Summary: This issue proposes adding an experiment flag to Dart for enum shorthands, a potential new language feature. The flag would allow developers to opt-in to the feature and provide a mechanism for gradual rollout and testing.

@dart-github-bot dart-github-bot added area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Nov 5, 2024
@devoncarew devoncarew removed the triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. label Nov 6, 2024
copybara-service bot pushed a commit that referenced this issue Nov 7, 2024
@kallentu
Add experiment flag for enum shorthands.
8b3c5aa 
This CL adds an experiment flag named `enum-shorthands`. We can start prototyping the work needed for the feature under the flag.

Bug: #57037
Change-Id: I5d5e679b20f993e0af59ce5b2d28e47269ecaedb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393521
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Nate Bosch <[email protected]>
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>
@kallentu kallentu changed the title [Enum Shorthands] Experiment flag [Dot Shorthands] Experiment flag Jan 31, 2025
copybara-service bot pushed a commit that referenced this issue Feb 7, 2025
@kallentu
[dot-shorthands][co19] Rename enum-shorthands flag to dot-shorthands …
89e545c 
…(and roll co19 to b14b080)

We've decided to rename enum shorthands to dot shorthands. It describes the entire feature better. It's not only for enum values. We'll update the experiment name before the implementation goes in, that way our users can use a flag that matches the actual feature name.

Additionally, roll co19 to b14b0802e696a60c79b00d0f052e26fb986f0faf so we can avoid an infra failure with co19 using what's now an unknown feature flag (enum-shorthands).

2025-02-06 [email protected] Fixes dart-lang/co19#3067. Rename the static access shorthand feature experiment flag (dart-lang/co19#3068)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Bug: #57037
Change-Id: I031e3bce8166145b24dbb77acf259d78e6e00f0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407603
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>
@mit-mit
Copy link
Member

mit-mit commented Apr 24, 2025 •
edited
Loading

@kallentu I think this (or at least first two checklist entries) is done?

@kallentu
Copy link
Member Author

Yep, first two are complete. Will be waiting on the last checklist item until closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kallentu kallentu

Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). feature-dot-shorthands Implementation of the dot shorthands feature. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@devoncarew @mit-mit @kallentu @dart-github-bot