Skip to content

#2641. Add import prefix tests #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a couple of adjustments!

@sgrekhov
Copy link
Contributor Author

Thank you! I misread the spec. Updated.
Please also note that there is a typo in the spec dart-lang/language#3827

@sgrekhov sgrekhov requested a review from eernstg May 22, 2024 12:40
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 4c46615 into dart-lang:master May 22, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 24, 2024
2024-05-24 [email protected] Fixes dart-lang/co19#2684. Update expected errors positions for CFE (dart-lang/co19#2685)
2024-05-24 [email protected] dart-lang/co19#2641. Add wildcards do not shadow tests (dart-lang/co19#2683)
2024-05-23 [email protected] dart-lang/co19#2641. Add patterns tests (dart-lang/co19#2682)
2024-05-22 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one enum member named `_` (dart-lang/co19#2674)
2024-05-22 [email protected] dart-lang/co19#2641. Add import prefix tests (dart-lang/co19#2681)
2024-05-22 [email protected] dart-lang/co19#2641. Add record types tests (dart-lang/co19#2679)
2024-05-22 [email protected] dart-lang/co19#2641. Add local functions test (dart-lang/co19#2680)
2024-05-22 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one extension type member named `_` (dart-lang/co19#2675)
2024-05-21 [email protected] dart-lang/co19#2641. Add late variables named `_` tests (dart-lang/co19#2677)
2024-05-21 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one extension member named _ (dart-lang/co19#2676)
2024-05-19 [email protected] Fixes dart-lang/co19#2660. Add missing import to augmented_expression_A01_t05_lib.dart (dart-lang/co19#2673)
2024-05-17 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one mixin member named `_` (dart-lang/co19#2672)
2024-05-17 [email protected] dart-lang/co19#2641. Wildcards. Update expected errors positions for CFE (dart-lang/co19#2671)

Change-Id: Ia94383cb2dc2a5912950ee3e13ee93a9576f3500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367963
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants