#2641. Add patterns tests #2682
Conversation
There was a problem hiding this comment.
Looks good! However, it isn't entirely obvious to me why these tests have a relationship with the wildcarded variable feature, and why they aren't just duplicates of existing tests about patterns?
(There's a lot of similar elements in 'LanguageFeatures/Patterns/wildcards_A*.dart').
I think there was an interaction between wildcard patterns and wildcarded variable declarations that came up recently, but I can't remember it right now. Is there something which is actually new here?
|
Yes, there are duplicated elements but not entierly. These tests check wildcards in more details, in particular wildcards assignment. Patterns tests more tests But if you insists I can move them to the |
|
OK, thanks! I think it would indeed be helpful to move them to |
|
No problem. Please review |
2024-05-24 [email protected] Fixes dart-lang/co19#2684. Update expected errors positions for CFE (dart-lang/co19#2685) 2024-05-24 [email protected] dart-lang/co19#2641. Add wildcards do not shadow tests (dart-lang/co19#2683) 2024-05-23 [email protected] dart-lang/co19#2641. Add patterns tests (dart-lang/co19#2682) 2024-05-22 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one enum member named `_` (dart-lang/co19#2674) 2024-05-22 [email protected] dart-lang/co19#2641. Add import prefix tests (dart-lang/co19#2681) 2024-05-22 [email protected] dart-lang/co19#2641. Add record types tests (dart-lang/co19#2679) 2024-05-22 [email protected] dart-lang/co19#2641. Add local functions test (dart-lang/co19#2680) 2024-05-22 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one extension type member named `_` (dart-lang/co19#2675) 2024-05-21 [email protected] dart-lang/co19#2641. Add late variables named `_` tests (dart-lang/co19#2677) 2024-05-21 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one extension member named _ (dart-lang/co19#2676) 2024-05-19 [email protected] Fixes dart-lang/co19#2660. Add missing import to augmented_expression_A01_t05_lib.dart (dart-lang/co19#2673) 2024-05-17 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one mixin member named `_` (dart-lang/co19#2672) 2024-05-17 [email protected] dart-lang/co19#2641. Wildcards. Update expected errors positions for CFE (dart-lang/co19#2671) Change-Id: Ia94383cb2dc2a5912950ee3e13ee93a9576f3500 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367963 Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]>
No description provided.