#3057. Add switch-expression tests #3135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrekhov
requested review from
eernstg,
athomas and
chloestefantsova
and removed request for
athomas
eernstg
reviewed
Apr 7, 2025
There was a problem hiding this comment.
Looks good, with a couple of typos.
One issue should be considered, though: We don't have a specification of switch expressions, but (worse) we also don't have a specification of the flow analysis of pattern matching (which would make a huge difference for switch expression as well as switch statements).
I think we might well have covered much of this based on the ordering considerations that were part of the discussions about pattern tests, but there could still be some lack of coverage. I created an issue (mentioned in a comment).
So I think we can land this PR when the typos have been fixed, but then we probably need to think about further testing of similar constructs (involving pattern matching and/or other recent features).
TypeSystem/flow-analysis/reachability_switch_expression_A01_t01.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A01_t01.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A02_t03.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
Apr 8, 2025
TypeSystem/flow-analysis/reachability_switch_expression_A01_t01.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A01_t01.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A02_t03.dart
Outdated
Show resolved
Hide resolved
eernstg
approved these changes
Apr 8, 2025
TypeSystem/flow-analysis/reachability_switch_expression_A01_t01.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A01_t01.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A02_t03.dart
Outdated
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 11, 2025
2025-04-10 [email protected] dart-lang/co19#3057. Add more flow analysis tests for while loop (dart-lang/co19#3141) 2025-04-10 [email protected] dart-lang/co19#2119. Rename unary_minus.dart to be visible for the test runner (dart-lang/co19#3140) 2025-04-09 [email protected] dart-lang/co19#3057. Add flow analysis try-finally tests (dart-lang/co19#3139) 2025-04-08 [email protected] Fixes dart-lang/co19#3136. Update expected errors location in initializer_not_a_constant_t03.dart (dart-lang/co19#3138) 2025-04-08 [email protected] dart-lang/co19#3057. Add flow analysis try-catch tests (dart-lang/co19#3137) 2025-04-08 [email protected] dart-lang/co19#3057. Add switch-expression tests (dart-lang/co19#3135) 2025-04-07 [email protected] Fixes dart-lang/co19#3133. Fix language version format. (dart-lang/co19#3134) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ibef7bb6dbc070122711ade17173946466f468a7e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422060 Reviewed-by: Chloe Stefantsova <[email protected]> Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Chloe Stefantsova <[email protected]> Auto-Submit: Sergey Grekhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.