Skip to content

#3057. Add flow analysis try-catch tests #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

#3057. Add flow analysis try-catch tests #3137

merged 3 commits into from
Apr 8, 2025

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Apr 8, 2025

No description provided.

eernstg
eernstg reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one tiny thing: We might want to try both orderings in a couple of cases where two constructs play a similar role and the requirement is just that "one kind of thing most be in one construct, another kind in the other construct".

@sgrekhov
Copy link
Contributor Author

sgrekhov commented Apr 8, 2025

Thanks. Reordered. PTAL

@sgrekhov sgrekhov requested a review from eernstg April 8, 2025 10:44
eernstg
eernstg approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit d1efea3 into dart-lang:master Apr 8, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 11, 2025
@sgrekhov
[co19] Roll co19 to 4ebc13c27af77129889a11fd1f95cff04dccd8f9
929657a 
2025-04-10 [email protected] dart-lang/co19#3057. Add more flow analysis tests for while loop (dart-lang/co19#3141)
2025-04-10 [email protected] dart-lang/co19#2119. Rename unary_minus.dart to be visible for the test runner (dart-lang/co19#3140)
2025-04-09 [email protected] dart-lang/co19#3057. Add flow analysis try-finally tests (dart-lang/co19#3139)
2025-04-08 [email protected] Fixes dart-lang/co19#3136. Update expected errors location in initializer_not_a_constant_t03.dart (dart-lang/co19#3138)
2025-04-08 [email protected] dart-lang/co19#3057. Add flow analysis try-catch tests (dart-lang/co19#3137)
2025-04-08 [email protected] dart-lang/co19#3057. Add switch-expression tests (dart-lang/co19#3135)
2025-04-07 [email protected] Fixes dart-lang/co19#3133. Fix language version format. (dart-lang/co19#3134)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ibef7bb6dbc070122711ade17173946466f468a7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422060
Reviewed-by: Chloe Stefantsova <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
Auto-Submit: Sergey Grekhov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg