Support URIs in part-of directives. #626
Conversation
test/splitting/function_types.unit
Outdated
| <<< | ||
| Function(parameter1, | ||
| void printFn(param1, param2)) f; | ||
| >>> |
There was a problem hiding this comment.
[nit] no name on this one? what is interesting about having a shorter first parameter?
There was a problem hiding this comment.
Yeah, not all of the tests have descriptions. I try to add them when it's worthwhile, but it's often obvious from the test.
In this case, it was an accidental copy/paste error and is redundant with the above one. Removed it.
| VerylongParameterType | ||
| parameterName) f; | ||
| >>> split in function type and on variable name | ||
| Function(VeryVeryVeryVeryLongParameterType) veryLongVariableName; |
There was a problem hiding this comment.
[nit] this isn't a VeryVeryVeryVeryLongParameterType it's a veryVeryVeryVeryLongParameterName
There was a problem hiding this comment.
It is actually a type (though it doesn't matter either way for this test). Unlike the old function type syntax, the new syntax wisely assumes if you omit one identifier, you're omitting the name, not the type.
| Function(int, String, Function(parameter1, parameter2, parameter3)) f; | ||
| <<< | ||
| Function( | ||
| int, |
There was a problem hiding this comment.
[nit] this is misleading... IIUC this is a parameter named 'int' of type 'dynamic'. Or am I wrong?
Fix #615.