Skip to content

Add a test for getter doc inheritance when overridden by variable. #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 8, 2018

Conversation

jcollins-g
Copy link
Contributor

#1779 is actually fixed by #1765, but #1765 includes no test for the issue in #1779. This adds the test.

Submit after #1765 lands.

@jcollins-g jcollins-g requested review from devoncarew and pq October 4, 2018 23:07
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jcollins-g jcollins-g merged commit f5a64a8 into master Oct 8, 2018
@jcollins-g jcollins-g deleted the mixins+getter_doc_inheritance branch October 8, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants