-
Notifications
You must be signed in to change notification settings - Fork 382
Ignore charset encoding in header #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove charset from "Content-Type" header Now the null value will be reflected for the charset in the header.
Remove charset from "Content-Type" header Now the null value will be reflected for the charset in the header.
Remove charset from "Content-Type" header Now the null value will be reflected for the charset in the header.
Remove charset from "Content-Type" header Now the null value will be reflected for the charset in the header.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jonasfj
I'm not sure if this is breaking or not...
lib/src/base_client.dart
Outdated
request.bodyFields = body.cast<String, String>(); | ||
} else { | ||
throw new ArgumentError('Invalid request body "$body".'); | ||
if(encoding != null) request.encoding = encoding; else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to run dartfmt
and the body of the if
needs to be wrapped in {}
.
Remove charset from "Content-Type" header Now the null value will be reflected for the charset in the header.
# Conflicts: # lib/src/request.dart
The PR description isn't very descriptive. Can you please edit it to say what this is and why we (all Dart HTTP users) need it? Have you considered how this will work with Request.encoding? |
Ah, reviewing #184 I think I see that this PR is trying to address that issue specifically? Parts of this change is a bit misleading since this doesn't really have anything to do with encoding, but is about whether we latch the charset on in Content-Type. Another aside is that something like this definitely needs tests. |
Closing as CLA wasn't signed |
I need to ignore the charset in the header.
Issue #15
issue #225