Skip to content

--[no-]analytics is deprecated. Use --suppress-analytics to disable analytics for one run instead. #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcharkes opened this issue Oct 3, 2023 · 3 comments · Fixed by #155

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Oct 3, 2023

@jonasfj @sigurdm Do I need to check what version of Dart we're running before deciding which of the two flags to use? Or did --suppress-analytics get added a while back already?

@dcharkes dcharkes transferred this issue from dart-lang/sdk Oct 3, 2023
@sigurdm
Copy link

sigurdm commented Oct 9, 2023

--suppress-analytics was added to the sdk in 68353d76a495b10eee0c6fc8c05e8a836a8577b7

That was for v. 3.0.0 I believe.

> git co 68353d76a495b10eee0c6fc8c05e8a836a8577b7
> $ tail tools/VERSION 
#
#  * Making cherry-picks to stable channel
#     - increase PATCH by 1
#
CHANNEL be
MAJOR 3
MINOR 0
PATCH 0
PRERELEASE 0
PRERELEASE_PATCH 0

@sigurdm
Copy link

sigurdm commented Oct 9, 2023

When are you using the flag?

I believe you can also suppress analytics by setting some env variable (Maybe CI or BOT) but that might be a misuse...

@dcharkes
Copy link
Collaborator Author

When are you using the flag?

Future<void> runPubGet({
required Uri workingDirectory,
required Logger logger,
}) async {
final result = await runProcess(
executable: Uri.file(Platform.resolvedExecutable),
arguments: ['pub', '--no-analytics', 'get'],
workingDirectory: workingDirectory,
logger: logger,
);
expect(result.exitCode, 0);
}

It's probably fine to bump it to --suppress-analytics, we already require Dart SDK 3.0 in the pubspec.

HosseinYousefi pushed a commit that referenced this issue Nov 16, 2023
…246)

* Add pubspec.lock from JNI example to git. 
This file should be checked in.

* Remove ffi patch and instead depend on the internals of a pinned package:ffi version (closes #149)
* Add new tests on GlobalJniEnv
* Rename findJniClass -> findJClass
* Locking around method/field lookups. (closes #85)
* Rename asJString and asDartString to toJStringPtr and toDartString for uniform naming
* Rename JniClass -> JClass
* Compare bindings normally and fallback to ignoring spaces
HosseinYousefi pushed a commit that referenced this issue Nov 16, 2023
…246)

* Add pubspec.lock from JNI example to git. 
This file should be checked in.

* Remove ffi patch and instead depend on the internals of a pinned package:ffi version (closes #149)
* Add new tests on GlobalJniEnv
* Rename findJniClass -> findJClass
* Locking around method/field lookups. (closes #85)
* Rename asJString and asDartString to toJStringPtr and toDartString for uniform naming
* Rename JniClass -> JClass
* Compare bindings normally and fallback to ignoring spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants