-
Notifications
You must be signed in to change notification settings - Fork 68
[c_compiler] package name #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mezoni The |
For reference: Rust calls it's C compiler wrapper package Some more notes dug up somewhere from @devoncarew and me:
And notes from @jonasfj:
|
@devoncarew I can't make new labels in this package or rename the existing label |
You should have more than sufficient permissions to (a repo committer can modify labels). |
Ah, it's not in the "settings" part. Done. |
…246) * Add pubspec.lock from JNI example to git. This file should be checked in. * Remove ffi patch and instead depend on the internals of a pinned package:ffi version (closes #149) * Add new tests on GlobalJniEnv * Rename findJniClass -> findJClass * Locking around method/field lookups. (closes #85) * Rename asJString and asDartString to toJStringPtr and toDartString for uniform naming * Rename JniClass -> JClass * Compare bindings normally and fallback to ignoring spaces
…246) * Add pubspec.lock from JNI example to git. This file should be checked in. * Remove ffi patch and instead depend on the internals of a pinned package:ffi version (closes #149) * Add new tests on GlobalJniEnv * Rename findJniClass -> findJClass * Locking around method/field lookups. (closes #85) * Rename asJString and asDartString to toJStringPtr and toDartString for uniform naming * Rename JniClass -> JClass * Compare bindings normally and fallback to ignoring spaces
We can't use
package:c_compiler
as a package name.ccompilers is an outdated package which hasn't been touched for 4 years.
The reason we went for
c_compiler
is that we could have arust_compiler
package etc.Suggestion by @jonasfj:
native_toolchain_c
.The upside of that name is it has 'native' which makes it fit with the other native packages in this repo.
The downside is that the package name is considerably longer.
Blocks:
@devoncarew @mit-mit @HosseinYousefi any opinions?
The text was updated successfully, but these errors were encountered: