[native_assets_builder] Build result is half-fed into link result

[dcharkes]

I found this weird code in Flutter tools:

    dependencies.addAll(buildResult.dependencies);
    if (!linkingEnabled) {
      assets.addAll(buildResult.encodedAssets);
    } else {
      // invoke link
      assets.addAll(linkResult.encodedAssets);
      dependencies.addAll(linkResult.dependencies);

It turns out the dependencies for the build and link hook must be combined by the caller but the encodedAssets from the build result are added to the link result, this isn't symmetric.

native/pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart

Line 192 in 5f978b4

var hookResult = HookResult(encodedAssets: buildResult.encodedAssets);

This line should be removed to make it symmetric, or the dependencies should be added there to make it symmetric.

This will need a manual roll into Dart & Flutter.