Skip to content

[native_assets_builder] Fix 2149 #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[native_assets_builder] Fix 2149 #2171

merged 1 commit into from
Apr 4, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 4, 2025

Closes: #2149

Requires a fix in SDKs when rolled.

Copy link

github-actions bot commented Apr 4, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 85.166% (+0.002%) from 85.164%
when pulling 0904c07 on fix-2149
into dd891c8 on main.

@dcharkes dcharkes merged commit d40127d into main Apr 4, 2025
32 checks passed
@dcharkes dcharkes deleted the fix-2149 branch April 4, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native_assets_builder] Build result is half-fed into link result
3 participants