-
Notifications
You must be signed in to change notification settings - Fork 68
[native_assets_cli] Add user_defines
#2165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
5514561
to
6041be6
Compare
6041be6
to
fff25a7
Compare
fff25a7
to
3525c01
Compare
3525c01
to
28009f3
Compare
mosuem
approved these changes
Apr 4, 2025
803df09
to
22b0a86
Compare
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 10, 2025
Updating the dart-lang/native dependencies to the ones published yesterday. Incorporates a fix for: * dart-lang/native#2149 * Note that a bunch of tests were relying on ignoring build assets. The tests have been fixed. And the new `AssetRouting` syntax in the build hook for sending assets to the link hook: * dart-lang/native#2164 Does not include support for user-defines in the pubspec yet. Will do this in a follow up PR. * dart-lang/native#2165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
package:hooks_runner
package:hooks
type-infra
A repository infrastructure change or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #39
Note passing in the user-defines should be done by the Dart and Flutter SDK, they need to decide where to take the command-line arguments, and how to read from the
pubspec.yaml
.The
NativeAssetsBuildRunner
provides a suggestion about where to put user-defines in thepubspec.yaml
:Moreover, it provides a helper function that can be reused in SDKs after the pubspec yaml is parsed.
Design choices
(According to the discussion on the bug.)
Test
This change is tested by invoking the build with user-defines, and in the hook failing if the defines are not available.