Skip to content

[jnigen] Add Android emulator to CI #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 15, 2025
Merged

[jnigen] Add Android emulator to CI #2206

merged 6 commits into from
Apr 15, 2025

Conversation

HosseinYousefi
Copy link
Member

Closes #1155.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:jnigen labels Apr 15, 2025
@github-actions GitHub Actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Apr 15, 2025 •
edited
Loading

Coverage Status

coverage: 79.346% (+2.2%) from 77.114%
when pulling 848e384 on emulator-ci
into 67cf48c on main.

dcharkes
dcharkes approved these changes Apr 15, 2025
View reviewed changes
pkgs/jnigen/test/simple_package_test/runtime_test_registrant.dart
@@ -742,7 +742,7 @@ void registerTests(String groupName, TestRunnerCallback test) {
// listener, it will work.
runner.runOnAnotherThreadAndJoin();
await completer.future;
expect(MyRunnable.$impls, hasLength(1));
expect(MyRunnable.$impls, hasLength(1), skip: Platform.isAndroid);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some documentation why this needs to be skipped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are below it, will move it up.

@HosseinYousefi HosseinYousefi mentioned this pull request Apr 15, 2025
Closed
@HosseinYousefi
Copy link
Member Author

Will address the actual test failures uncovered by the addition of the emulator test in a separate PR: #2207

@HosseinYousefi
Copy link
Member Author

It will actually be solved by using a higher api level, as our tests are written with Java 8+ features.

@HosseinYousefi HosseinYousefi merged commit 231e45f into main Apr 15, 2025
26 of 28 checks passed
@HosseinYousefi HosseinYousefi deleted the emulator-ci branch April 15, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcharkes dcharkes dcharkes approved these changes

@liamappelbe liamappelbe Awaiting requested review from liamappelbe

Assignees
No one assigned
Labels
package:jnigen skip-changelog-check type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests with Android emulator to CI
3 participants
@HosseinYousefi @coveralls @dcharkes