Skip to content

[native_assets_cli] Cleanup JSON: old asset encoding #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

dcharkes
Copy link
Collaborator

Bug:

Cleanup from:

Once this rolls into Dart and Flutter, older hooks will be broken. The oldest version of the hooks that still works is 0.15.0 of native_assets_cli as tested in pkgs/native_assets_builder/test_data/native_add_version_skew/pubspec.yaml.

Once this is used in hooks, those hooks on older SDKs will be broken. Resolving newer versions of this package on older SDKs is prevented by the lower bound SDK constraint.

Copy link

github-actions bot commented Apr 22, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_builder Breaking 0.16.0 0.17.0-wip 0.17.0 ✔️
native_assets_cli Breaking 0.16.0 0.17.0-wip 0.17.0 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes merged commit fdd7672 into main Apr 22, 2025
36 of 37 checks passed
@dcharkes dcharkes deleted the json-cleanup-asset-types branch April 22, 2025 15:38
@coveralls
Copy link

Coverage Status

coverage: 77.66% (+1.9%) from 75.809%
when pulling 7b6cb42 on json-cleanup-asset-types
into 4e1ef75 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants