Skip to content

[native_assets_cli] Remove fallback JSON encodings #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
15 tasks done
dcharkes opened this issue Apr 14, 2025 · 1 comment
Closed
15 tasks done

[native_assets_cli] Remove fallback JSON encodings #2199

dcharkes opened this issue Apr 14, 2025 · 1 comment
Assignees
@dcharkes
Labels
package:hooks
Milestone
Native Assets v1.0

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Apr 14, 2025 •
edited
Loading

The protocol still has a bunch of fallbacks that can be cleaned up.

  • architecture and OS in code assets
  • old asset-types (non-package-namespaced)
  • old config keys (non-package-namespaced)
  • old asset encoding (not nested under encoding in asset)
  • old config encoding (not nested under extensions)
  • out_dir
  • version
  • out_file is now required
  • CCompilerConfig.envScript
  • assetsForLinking
  • prefer-static & prefer-dynamic
  • after 0.14.0 is in Flutter 2 weeks (24 april)
    • old metadata
  • after 0.16.0 is in Flutter 2 weeks (30 april) flutter/flutter@83b2f7f 3.9.0-21.0.dev
    • old user-defines encoding (not nested under workspace_pubspec->defines)

We should wait a couple of weeks, and then start cleaning these up.
@dcharkes dcharkes added this to the Native Assets v1.0 milestone Apr 14, 2025
@dcharkes dcharkes self-assigned this Apr 17, 2025
@dcharkes dcharkes moved this to In Progress in Native Assets Apr 17, 2025
@dcharkes dcharkes mentioned this issue Apr 22, 2025
Merged
auto-submit bot pushed a commit that referenced this issue Apr 22, 2025
@dcharkes
[native_assets_cli] Cleanup JSON: Code Asset OS and Architecture (#2219)
4e1ef75 
Bug:

* #2199

Cleanup from:

* #2127
This was referenced Apr 22, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dcharkes
Copy link
Collaborator Author

Removed from this repo.

Rolled into Dart in: https://dart-review.googlesource.com/c/sdk/+/424061

Will roll into Flutter in: flutter/flutter#167665

@github-project-automation github-project-automation bot moved this from In Progress to Done in Native Assets Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
package:hooks
Projects
Native Assets
Status: Done
Milestone
Native Assets v1.0
Development

No branches or pull requests
1 participant
@dcharkes