Skip to content

[native_assets_cli] Cleanup JSON: env_script and env_script_arguments #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_cli Breaking 0.16.0 0.17.0-wip 0.17.0 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Copy link

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from json-cleanup-prefer-static to main April 23, 2025 08:09
@dcharkes dcharkes force-pushed the json-cleanup-envscript branch from af2a1aa to 3d8d361 Compare April 23, 2025 08:10
@dcharkes dcharkes merged commit 3c976fd into main Apr 23, 2025
29 checks passed
@dcharkes dcharkes deleted the json-cleanup-envscript branch April 23, 2025 08:20
@coveralls
Copy link

Coverage Status

coverage: 77.298% (-0.2%) from 77.475%
when pulling 3d8d361 on json-cleanup-envscript
into f36662f on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants