Skip to content

[native_assets_cli] Cleanup JSON: old user defines #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 23, 2025

Bug:

Cleanup of:

The old JSON encoding was only replaced one week ago, but it was only in the SDK for a week. So remove the fallback encoding now anyways. If anyone adopted it last week, they know where to update it.

This PR also adds tests for the JSON schema, that were missing:

  • user_defines is optional, there might not be any
    • pub_workspace is optional, there might be SDKs without a pubspec.
      • base_path is required. If there are any user-defines, they might have relative paths in them.
      • defines is required. If there are no defines, then the whole pub_workspace should be omitted. (Or simply add an empty map.)

Copy link

github-actions bot commented Apr 23, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_cli Breaking 0.16.0 0.17.0-wip 0.17.0 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 77.244% (+0.09%) from 77.155%
when pulling 583dd95 on json-cleanup-user-defines
into c159731 on main.

Copy link

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes merged commit ea1584b into main Apr 23, 2025
47 of 49 checks passed
@dcharkes dcharkes deleted the json-cleanup-user-defines branch April 23, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants