[native_assets_cli] Cleanup JSON: old user defines #2227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
Cleanup of:
The old JSON encoding was only replaced one week ago, but it was only in the SDK for a week. So remove the fallback encoding now anyways. If anyone adopted it last week, they know where to update it.
This PR also adds tests for the JSON schema, that were missing:
user_defines
is optional, there might not be anypub_workspace
is optional, there might be SDKs without a pubspec.base_path
is required. If there are any user-defines, they might have relative paths in them.defines
is required. If there are no defines, then the wholepub_workspace
should be omitted. (Or simply add an empty map.)