Fix #28 -- escaping arguments as mentioned in TODO #2093
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Mar 7, 2019
lib/src/command_runner.dart
Outdated
| // Escape the argument for users to copy-paste in bash. | ||
| protectArgument(String x) => | ||
| RegExp(r'^[a-zA-Z0-9-_]+$').stringMatch(x) == null | ||
| ? "'${x.replaceAll("'", "'\\''")}'" |
There was a problem hiding this comment.
You cannot escape a single quote inside a single quote:
https://www.gnu.org/software/bash/manual/html_node/Single-Quotes.html#Single-Quotes
You probably need to use double quotes and escape all of ‘$’, ‘`’, ‘\’
There was a problem hiding this comment.
Not really... Read carefully I escape single quote, by ending single quotation then having an escaped single quote and starting single quotation again :)
If there is no space between end and start of single quotation it doesn't become a new argument...
There was a problem hiding this comment.
Explain this in a comment ...
sigurdm
approved these changes
Mar 7, 2019
sigurdm
reviewed
Mar 7, 2019
lib/src/command_runner.dart
Outdated
| // Escape the argument for users to copy-paste in bash. | ||
| protectArgument(String x) => | ||
| RegExp(r'^[a-zA-Z0-9-_]+$').stringMatch(x) == null | ||
| ? "'${x.replaceAll("'", "'\\''")}'" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just want to close: #28