Skip to content

Use forward slashes in paths when using path dependencies from git dependencies #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Jun 25, 2024

Fixes #4314

@sigurdm sigurdm requested a review from jonasfj June 25, 2024 09:50
@CodeDoctorDE
Copy link

is there an option to put this in a hotfix for flutter? I'm really interested having this fixed for my git dependencies

@sigurdm
Copy link
Contributor Author

sigurdm commented Jul 1, 2024

is there an option to put this in a hotfix for flutter? I'm really interested having this fixed for my git dependencies

Could you live with a cherry-pick to the dart 3.5/flutter 3.24 beta?

@CodeDoctorDE
Copy link

It's okay for me, thanks <3

@sigurdm
Copy link
Contributor Author

sigurdm commented Jul 1, 2024

Ok - I'll first roll this to the sdk - then file a cherry-pick request to beta.

I think we need this #4321 to get ci passing...

@sigurdm sigurdm closed this Jul 1, 2024
@sigurdm sigurdm reopened this Jul 1, 2024
@sigurdm sigurdm merged commit ea4a1c8 into dart-lang:master Jul 1, 2024
44 of 45 checks passed
@sigurdm
Copy link
Contributor Author

sigurdm commented Jul 5, 2024

This should be in the latest beta now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path is inconsistent on windows when using git dependency with path dependencies
3 participants