[CP] Pub: Fix to using path dependencies in git dependencies on windows

[sigurdm]

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/373861 (rolling dart-lang/pub#4315)

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/373861

Issue Description

On windows the path would be written with a \ instead of / the pubspec lock, making it incompatible with the mac/linux pubspec.lock

What is the fix

Always use '/' in pubspec.lock for path-dependencies in git-dependencies.

Why cherry-pick

Windows users using the path-dependencies from git-dependencies feature are impacted, and will get an inconsistent pubspec.lock.

Risk

Low

Issue link(s)

dart-lang/pub#4314

Extra Info

We could consider also picking this to stable, but given that this was only discovered late, it might not be a broadly used feature, and we can get away with a beta CP.

[jonasfj]

Support for relative path-dependencies from git-dependencies was introduced in Dart 3.4, this bug has existed since.

I don't think the feature has been widely promoted.

But it would be nice to get the fix into 3.5.

[itsjustkevin]

@sigurdm and @jonasfj we have not cut the final beta, if this change has already landed on main, it will be included in the next beta, ensuring that it is available for the 3.5 release. I am going to close this issue, please reopen if I understood incorrectly.