-
Notifications
You must be signed in to change notification settings - Fork 230
Allow multiple build for different type of OS. #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c4ae577
to
05bc34e
Compare
@jakemac53 – is there a way to set this up w/ mono_repo? |
If it’s possible then will be good since we don’t need to create an explicit matrix. Expect we of course still can exclude several things that don’t need to be build inside of the job. |
mono_repo does support os:
- linux
- windows
- osx |
05bc34e
to
d9ab820
Compare
For travis I guess there's also a problem for the Windows dll build, for FFI samples. However I can't test it on my PC. Please see https://travis-ci.org/github/dart-lang/samples/jobs/670278306?utm_medium=notification&utm_source=github_status As for
But seems like the expansion didn't work for all of the os. https://travis-ci.org/github/dart-lang/samples/builds/670381077?utm_source=github_status&utm_medium=notification. Let me know if there's still something off with the config. Thank you.. |
I believe this is the start of a fix for #46 |
@domesticmouse Yes it is.. the build config that managed to fix this is writing all of the possible combination for all of the build stages. But this is really inefficient, in the term of lines addition. The goal is since this is something like "Hello World" I hope people can easily look at the working example. Any documentation on how mono_repo config works? I'm never use that before. Example of fixes related to FFI is including #44. |
Hey @kevmoo, can you help out with configuring |
@irvifa The You can see an example here https://github.com/dart-lang/build/blob/280cd60d74fe24e5a2f01032f4c5ffe3e9c4c5a6/_test/mono_pkg.yaml#L4 which also has examples of overriding specific tasks to run only on a certain os. |
@jakemac53 I think that's because of the fact that top level mono_repo is https://github.com/dart-lang/build/blob/280cd60d74fe24e5a2f01032f4c5ffe3e9c4c5a6/mono_repo.yaml So the mono_repo you mentioned before linked to the top level mono_repo, please cmiiw.. |
@irvifa I am not sure what you are asking exactly - but what you need to do is put the |
766e646
to
ef32f19
Compare
ef32f19
to
18d04cc
Compare
@jakemac53 Can you help me review this PR? I exclude the windows as allowed to fail since I can't exactly test the |
I can send an alternate PR here to show what I mean about the config, give me a minute. You can also choose which jobs should run on which OS instead of allowing all failures on osx/windows. |
see #48 |
No description provided.