Skip to content

Enable windows and osx tests #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 13, 2020
Merged

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Apr 7, 2020

Successor to #47

Fixes #46

Note that the FFI tests do not run on windows/osx, so those are excluded.

cc @irvifa

@jakemac53 jakemac53 requested a review from domesticmouse April 7, 2020 18:24
@jakemac53
Copy link
Contributor Author

ping @domesticmouse

@irvifa
Copy link

irvifa commented Apr 10, 2020

Thank you @jakemac53 now I learn how to use mono_repo 🙂

Copy link
Member

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@domesticmouse
Copy link
Member

@jakemac53 I believe you have squash & merge access to this repo, if not ping me to land this PR.

@jakemac53 jakemac53 merged commit d18af91 into master Apr 13, 2020
@jakemac53 jakemac53 deleted the enable-windows-and-osx-tests branch April 13, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add windows and macos in the travis os jobs.
4 participants