Skip to content

Analyzer should collect all the information it needs to reproduce a crash and automatically file a bug when it does so #28633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Feb 3, 2017 · 7 comments
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@Hixie
Copy link
Contributor

Hixie commented Feb 3, 2017

(This should be opt-in, for obvious reasons.)

The analyzer frequently crashes for me. It's always in really obscure cases like when I've just switched branches or when I've made some obscure syntax error that I've fixed by the time the analyzer crashes (because it read all the files up front then parsed then then crashed a minute later), or some such, and so I can never reproduce it.

I would love it if there was some way I could opt-in to having such crashes automatically wrap up all the input that it saw, zip it up, and upload it to github or wherever you need it to fix the crashes.

@bwilkerson bwilkerson added the legacy-area-analyzer Use area-devexp instead. label Feb 3, 2017
@bwilkerson
Copy link
Member

Actually, there already is. Just pass the command-line argument --instrumentation-log-file=... when starting up the analysis server (where the ellipsis is replaced by the absolute path (not URI) of the file you want it to write to). In IntelliJ you can do this by opening the 'Registry...' dialog ('Help' > 'Find Action...', the type 'Registry') and adding this to the entry named 'dart.server.additional.arguments'. The file will be overwritten every time you restart the analysis server.

Fair warning: the file contains all of the communications with the server, including the content of any files that were opened, all of the activity of server, including which files were analyzed, and other potentially sensitive data. Sending it via private e-mail is much safer than posting it to somewhere like github.

@Hixie
Copy link
Contributor Author

Hixie commented Feb 3, 2017

Ah, cool. Then please consider this bug to just be about the part where the uploading happens automatically. :-)

@bwilkerson
Copy link
Member

Yep. We're looking into that.

@Hixie
Copy link
Contributor Author

Hixie commented Feb 3, 2017

awesome!

@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Feb 17, 2017
@srawlins
Copy link
Member

@MichaelRFairhurst @scheglov is this fixed with our recent crash reporting work?

@MichaelRFairhurst
Copy link
Contributor

MichaelRFairhurst commented May 28, 2020 via email

copybara-service bot pushed a commit that referenced this issue Apr 14, 2023
This pulls in the `okToSend` method from dart-lang/tools#79 in the tools repository.

Bug: #28633
Change-Id: I512d041750050338699d3635ba426cc0acdd5a20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295380
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Janice Collins <[email protected]>
Auto-Submit: Janice Collins <[email protected]>
@jcollins-g
Copy link
Contributor

PDD now approves of external crash reporting. It is now switched on under approved circumstances. I'm not sure what "automatically file a bug" would mean in this context, but closing as fixed as we should now have the data to make judgments on whether it should be reported.

copybara-service bot pushed a commit that referenced this issue Apr 20, 2023
…nism.

This pulls in the `okToSend` method from dart-lang/tools#79 in the tools repository.
A cherry pick will pull in several revisions from the tools repository as a result.  You can easily browse the affected revisions here:

https://github.com/dart-lang/tools/compare/0304fbb..2308c67

Bug: #28633
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/295380
Change-Id: I512d041750050338699d3635ba426cc0acdd5a20
Fixes: #52044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295386
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants