-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Analyzer should collect all the information it needs to reproduce a crash and automatically file a bug when it does so #28633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Actually, there already is. Just pass the command-line argument Fair warning: the file contains all of the communications with the server, including the content of any files that were opened, all of the activity of server, including which files were analyzed, and other potentially sensitive data. Sending it via private e-mail is much safer than posting it to somewhere like github. |
Ah, cool. Then please consider this bug to just be about the part where the uploading happens automatically. :-) |
Yep. We're looking into that. |
awesome! |
@MichaelRFairhurst @scheglov is this fixed with our recent crash reporting work? |
Unfortunately no. Only internally. Externally we have to go through PDDs etc
…On Wed, May 27, 2020, 9:48 PM Sam Rawlins ***@***.***> wrote:
@MichaelRFairhurst <https://github.com/MichaelRFairhurst> @scheglov
<https://github.com/scheglov> is this fixed with our recent crash
reporting work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28633 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMNM65LC4HHHEKNBAFAEETRTXUJ3ANCNFSM4C63UVAA>
.
|
This pulls in the `okToSend` method from dart-lang/tools#79 in the tools repository. Bug: #28633 Change-Id: I512d041750050338699d3635ba426cc0acdd5a20 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295380 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Janice Collins <[email protected]> Auto-Submit: Janice Collins <[email protected]>
PDD now approves of external crash reporting. It is now switched on under approved circumstances. I'm not sure what "automatically file a bug" would mean in this context, but closing as fixed as we should now have the data to make judgments on whether it should be reported. |
…nism. This pulls in the `okToSend` method from dart-lang/tools#79 in the tools repository. A cherry pick will pull in several revisions from the tools repository as a result. You can easily browse the affected revisions here: https://github.com/dart-lang/tools/compare/0304fbb..2308c67 Bug: #28633 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/295380 Change-Id: I512d041750050338699d3635ba426cc0acdd5a20 Fixes: #52044 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295386 Commit-Queue: Brian Wilkerson <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
(This should be opt-in, for obvious reasons.)
The analyzer frequently crashes for me. It's always in really obscure cases like when I've just switched branches or when I've made some obscure syntax error that I've fixed by the time the analyzer crashes (because it read all the files up front then parsed then then crashed a minute later), or some such, and so I can never reproduce it.
I would love it if there was some way I could opt-in to having such crashes automatically wrap up all the input that it saw, zip it up, and upload it to github or wherever you need it to fix the crashes.
The text was updated successfully, but these errors were encountered: