Add a okToSend getter to the Analytics class
#79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh very nice 😄 ! We should probably bump the version to 1.1.0 then right since we have exposed a new api? |
|
Yes. Added to pubspec and changelog, but let me know if you'd prefer to do that part yourself later and I'll remove it. |
|
You're all good to make those changes, you'll also need to update constants.dart, we send the version of the package to GA as well |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 14, 2023
This pulls in the `okToSend` method from dart-lang/tools#79 in the tools repository. Bug: #28633 Change-Id: I512d041750050338699d3635ba426cc0acdd5a20 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295380 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Janice Collins <[email protected]> Auto-Submit: Janice Collins <[email protected]>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 20, 2023
…nism. This pulls in the `okToSend` method from dart-lang/tools#79 in the tools repository. A cherry pick will pull in several revisions from the tools repository as a result. You can easily browse the affected revisions here: https://github.com/dart-lang/tools/compare/0304fbb..2308c67 Bug: #28633 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/295380 Change-Id: I512d041750050338699d3635ba426cc0acdd5a20 Fixes: #52044 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295386 Commit-Queue: Brian Wilkerson <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
dcharkes
pushed a commit
that referenced
this pull request
May 23, 2023
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@755da8c...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for the analyzer to use the same consent protocol for crash reporting as the rest of the analytics, we have to know dynamically whether or not it is OK to send a crash report. The
_clientShowedMessageprivate variable has no getter so it is not possible to reproduce the same check that Analytics uses internally. This small refactor adds a getter to provide a one-stop shop to check whether it is OK to send.