make spawnUri work at the same time in VM and frog/dart2js #3051
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
closed-obsolete
Closed as the reported issue is no longer relevant
library-isolate
Comments
|
Removed area-library label. |
|
Added Library-Isolates label. |
|
Removed Isolates label. |
|
Added Library-Isolate label. |
|
Removed Library-Isolates label. |
|
The current version of Isolate.spawnUri appends ".js" to the URI before loading it from javascript. Keeping a compiled JS version together with the original makes the URI work in both cases. Added AssumedStale label. |
sigmundch
added
Type-Defect
area-core-library
copybara-service bot
pushed a commit
that referenced
this issue
Jun 6, 2022
…5 revisions) https://dart.googlesource.com/dartdoc/+log/8549817bb1b5..f5bcc4bd46f4 2022-06-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 3.0.2 to 3.0.3 (#3058) 2022-06-02 [email protected] Issue #3052: up/down arrox bug fix (#3054) 2022-06-01 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 1.0.4 to 1.1.0 (#3053) 2022-05-25 [email protected] Require Dart 2.17, enable and fix latest lints (#3051) 2022-05-25 [email protected] Update styles.css (#3046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I6c49e95569b83b08c53158079febaeb8a9ab2f64 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247301 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Devon Carew <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
spawnUri currently takes a URL as an argument. This URL is the code to load, which is different if running the code in JS or in the dartvm.
A proposal is to add special support for frog/dart2js so we can make the URI be as it is expected by the dartvm: the URL is just like a #import directive.
The text was updated successfully, but these errors were encountered: