Skip to content

Double click in string interpolation selects too much #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bwilkerson opened this issue May 14, 2012 · 11 comments
Closed

Double click in string interpolation selects too much #3052

bwilkerson opened this issue May 14, 2012 · 11 comments
Assignees
@stevemessick
Labels
P3 A lower priority bug or feature request
Milestone
1.1

Comments

@bwilkerson
Copy link
Member

Given source like the following:

  "xxx $first$second yyy"

double clicking on the identifier "second" selects "$first$second". While this is a valid identifier outside a string interpolation (or inside a string interpolation expression enclosed in curly braces), in this case it's two separate identifiers. It would be nice if only "second" were selected.
@stevemessick
Copy link
Contributor

Set owner to @stevemessick.

@stevemessick
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Low label.

@clayberg
Copy link

clayberg commented Jun 1, 2012

Added this to the Later milestone.

@stevemessick
Copy link
Contributor

Removed this from the Later milestone.
Added this to the M3 milestone.

@danrubel
Copy link

Removed this from the M3 milestone.
Added this to the M2 milestone.

@clayberg
Copy link

clayberg commented Nov 9, 2012

Removed this from the M2 milestone.
Added this to the M3 milestone.

@clayberg
Copy link

Removed this from the M3 milestone.
Added this to the M4 milestone.

@clayberg
Copy link

Removed this from the M4 milestone.
Added this to the M5 milestone.

@stevemessick
Copy link
Contributor

Removed this from the M5 milestone.
Added this to the Later milestone.

@stevemessick
Copy link
Contributor

https://codereview.chromium.org/121733002/

Removed this from the Later milestone.
Added this to the 1.2 milestone.
Added Fixed label.

@clayberg
Copy link

clayberg commented Jan 2, 2014

Removed this from the 1.2 milestone.
Added this to the 1.1 milestone.

@bwilkerson bwilkerson added Type-Defect P3 A lower priority bug or feature request labels Jan 2, 2014
@bwilkerson bwilkerson added this to the 1.1 milestone Jan 2, 2014
copybara-service bot pushed a commit that referenced this issue Jun 6, 2022
Roll Dart Documentation Generator from 8549817bb1b5 to f5bcc4bd46f4 (…
3fd6912 
…5 revisions)

https://dart.googlesource.com/dartdoc/+log/8549817bb1b5..f5bcc4bd46f4

2022-06-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 3.0.2 to 3.0.3 (#3058)
2022-06-02 [email protected] Issue #3052: up/down arrox bug fix (#3054)
2022-06-01 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 1.0.4 to 1.1.0 (#3053)
2022-05-25 [email protected] Require Dart 2.17, enable and fix latest lints (#3051)
2022-05-25 [email protected] Update styles.css (#3046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I6c49e95569b83b08c53158079febaeb8a9ab2f64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247301
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevemessick stevemessick

Labels
P3 A lower priority bug or feature request
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
4 participants
@danrubel @bwilkerson @stevemessick @clayberg