Skip to content

html/window_open_test is failing in dart2js_drt_release_ia32 on Mac #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peter-ahe-google opened this issue Jun 15, 2012 · 2 comments
Closed

html/window_open_test is failing in dart2js_drt_release_ia32 on Mac #3671

peter-ahe-google opened this issue Jun 15, 2012 · 2 comments
Labels
closed-duplicate Closed in favor of an existing report

Comments

@peter-ahe-google
Copy link
Contributor

Content-Type: text/plain
FAIL
1 FAIL Expectation: TwoArgumentVersion. Caught NoSuchMethodException : method not found: 'close$0' Receiver: Arguments: []
TypeError: Object [object Window] has no method 'close$0'
    at $.closeWindow (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:3674:12)
    at Closure2.$$.Closure2.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:2794:5)
    at TestCase.$$.TestCase.test$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:1244:40)
    at Closure25.$$.Closure25.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:3029:19)
    at $.guardAsync (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:5005:20)
    at Function.$._nextBatch as $call$0
    at Closure6.$$.Closure6.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:2830:17)
    at Closure7.$$.Closure7.$call$2 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:2838:25)
    at _ReceivePortImpl.$$._ReceivePortImpl._callback$2 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:1447:60)
    at Closure15.$$.Closure15.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:2874:36)
2 FAIL Expectation: ThreeArgumentVersion. Caught NoSuchMethodException : method not found: 'close$0' Receiver: Arguments: []
TypeError: Object [object Window] has no method 'close$0'
    at $.closeWindow (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:3674:12)
    at Closure3.$$.Closure3.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:2802:5)
    at TestCase.$$.TestCase.test$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:1244:40)
    at Closure25.$$.Closure25.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:3029:19)
    at $.guardAsync (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:5005:20)
    at Function.$._nextBatch as $call$0
    at Closure6.$$.Closure6.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:2830:17)
    at Closure7.$$.Closure7.$call$2 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:2838:25)
    at _ReceivePortImpl.$$._ReceivePortImpl._callback$2 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:1447:60)
    at Closure15.$$.Closure15.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_window_open_test/test.js:2874:36)
Total 0 passed, 2 failed 0 errors

EOF
@peter-ahe-google
Copy link
Contributor Author

I think it is likely that this is a problem with dart2js or DRT.

I would appreciate if someone familiar with the test could do the initial evaluation, and assign it back to dart2js if (when) it is determined to be a dart2js bug.

@vsmenon
Copy link
Member

vsmenon commented Jun 20, 2012

Merging with Sam's related bug. I'll look into getting this test running.

Added Duplicate label.
Marked as being merged into #3472.

@peter-ahe-google peter-ahe-google added Type-Defect closed-duplicate Closed in favor of an existing report labels Jun 20, 2012
@vsmenon vsmenon mentioned this issue Jun 3, 2015
Closed
copybara-service bot pushed a commit that referenced this issue Dec 1, 2022
@sigurdm
Bump pub to 21aa23f148a428ae4dd97a27ecc70b08c1328089
258598e 
Changes:
```
> git log --format="%C(auto) %h %s" 4fd2051..21aa23f
 https://dart.googlesource.com/pub.git/+/21aa23f1 Revert "Create output folder if it doesn't exist in the precompiler (#3676)" (#3677)
 https://dart.googlesource.com/pub.git/+/04f7bce8 Don't consider resolution outdated in dev-releases (#3678)
 https://dart.googlesource.com/pub.git/+/74473e12 Create output folder if it doesn't exist in the precompiler (#3676)
 https://dart.googlesource.com/pub.git/+/5bfd68b1 Avoid .incremental.dill.incremental.dill in temporary file name (#3675)
 https://dart.googlesource.com/pub.git/+/c3870bc1 Unskip test (#3671)

```

Diff: https://dart.googlesource.com/pub.git/+/4fd2051bb8060ea2f2e02b13dfeb2f793d197994..21aa23f148a428ae4dd97a27ecc70b08c1328089/
Change-Id: Ie5060563cc3f96b0bc52e542f7a7b19d17fefd8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273223
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsmenon @peter-ahe-google