Skip to content

Editor template includes HTML that won't work over HTTPS #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Jun 15, 2012 · 8 comments
Closed

Editor template includes HTML that won't work over HTTPS #3676

DartBot opened this issue Jun 15, 2012 · 8 comments
Assignees
@devoncarew
Milestone
M1

Comments

@DartBot
Copy link

DartBot commented Jun 15, 2012

This issue was originally filed by [email protected]

The default application template includes this shim HTML:
  <script src="http://dart.googlecode.com/svn/branches/bleeding_edge/dart/client/dart.js&quot;&gt;&lt;/script>

Because of the 'http', some browsers (including Chrome) won't run the script if the HTML file was served over https.
Changing the url to https should work in all cases.
@anders-sandholm
Copy link
Contributor

Added Area-Editor, Triaged labels.

@clayberg
Copy link

Set owner to @devoncarew.

@clayberg
Copy link

Added this to the M1 milestone.

@devoncarew
Copy link
Member

Removed this from the M1 milestone.
Added this to the Later milestone.

@devoncarew
Copy link
Member

Vijay, I'm bumping this over to you as you've done a lot of work on the dart.js file. Is this a good idea, to always reference dart.js as an https resource (not http)? Will this cause problems?

cc @sethladd.
Set owner to @vsmenon.

@sethladd
Copy link
Contributor

An HTTP resource can include any number of https resources. This is a good idea.

@devoncarew
Copy link
Member

Bumping back to myself -

Set owner to @devoncarew.
Removed this from the Later milestone.
Added this to the M2 milestone.

@devoncarew
Copy link
Member

Removed this from the M2 milestone.
Added this to the M1 milestone.
Added Fixed label.

@DartBot DartBot added this to the M1 milestone Oct 10, 2012
copybara-service bot pushed a commit that referenced this issue Dec 1, 2022
@sigurdm
Bump pub to 21aa23f148a428ae4dd97a27ecc70b08c1328089
258598e 
Changes:
```
> git log --format="%C(auto) %h %s" 4fd2051..21aa23f
 https://dart.googlesource.com/pub.git/+/21aa23f1 Revert "Create output folder if it doesn't exist in the precompiler (#3676)" (#3677)
 https://dart.googlesource.com/pub.git/+/04f7bce8 Don't consider resolution outdated in dev-releases (#3678)
 https://dart.googlesource.com/pub.git/+/74473e12 Create output folder if it doesn't exist in the precompiler (#3676)
 https://dart.googlesource.com/pub.git/+/5bfd68b1 Avoid .incremental.dill.incremental.dill in temporary file name (#3675)
 https://dart.googlesource.com/pub.git/+/c3870bc1 Unskip test (#3671)

```

Diff: https://dart.googlesource.com/pub.git/+/4fd2051bb8060ea2f2e02b13dfeb2f793d197994..21aa23f148a428ae4dd97a27ecc70b08c1328089/
Change-Id: Ie5060563cc3f96b0bc52e542f7a7b19d17fefd8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273223
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devoncarew devoncarew

Labels
None yet
Projects
None yet
Milestone
M1
Development

No branches or pull requests
5 participants
@sethladd @devoncarew @anders-sandholm @clayberg @DartBot