Skip to content

[ffi] Support simulators simarm simarm64 #48365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcharkes opened this issue Feb 10, 2022 · 1 comment
Closed

[ffi] Support simulators simarm simarm64 #48365

dcharkes opened this issue Feb 10, 2022 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Feb 10, 2022 •
edited
Loading

We get more and more use cases where we would like test coverage with FFI in simulated architectures.

This is the overall tracking issue for full support.

Sub issues:
@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi labels Feb 10, 2022
@dcharkes dcharkes mentioned this issue Feb 10, 2022
Closed
@dcharkes
Copy link
Contributor Author

Duplicate of #37299

@dcharkes dcharkes marked this as a duplicate of #37299 Feb 14, 2022
@dcharkes dcharkes mentioned this issue Mar 26, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Apr 3, 2023
@dcharkes
[infra/ffi] Skip FFI tests on simulator

Verified

This commit was signed with the committer’s verified signature.
tractorss TurbanCoder
SSH Key Fingerprint: rAe7JODXAcIrxMeJ22Lm0fX+mTl5awjlFD0MQ2X+GYE
Verified
Learn about vigilant mode
7cfab4e 
Some recent infra shuffling [0] caused FFI tests not to be ingored on
some simulator architectures.

FFI is not supported on simulators, so ignore tests.

[0] https://dart-review.googlesource.com/c/sdk/+/286360

Bug: #48365
Change-Id: Id623733e89f4269feabbe1f1212bdb64a43d7540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292821
Auto-Submit: Daco Harkes <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcharkes